Partial mocks use class created by OCClassMock #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaclach
force-pushed
the
simple_partials
branch
from
24ca2bb
to
036739c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCClassMock creates a pair of classes, but only uses the meta class.
OCPartialClassMock creates another pair of classes, but only uses the actual class.
This change makes OCPartialClassMock use the class that is generated (but unused) by OCClassMock, simplifying the class tree, and removing one class that we don't need to dispose of.
This also fixed up one of the issues with KVO where we were potentially disposing the KVO class and throwing an exception.