Allow OCMock to be used with EarlGrey for UITesting #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaclach
force-pushed
the
macro_injection
branch
from
e2ee9bd
to
af39699
Compare
dmaclach
force-pushed
the
macro_injection
branch
from
af39699
to
9f173d0
Compare
dmaclach
changed the title
dmaclach
force-pushed
the
macro_injection
branch
from
9f173d0
to
a75522e
Compare
We have a need to inject a replacement for `OCMMacroState` for when we are doing cross process testing using a library like https://github.com/google/EarlGrey/tree/earlgrey2. This simple expansion to the basic macros will give us the flexibility we need to allow us to use OCMock v3 syntax instead of falling back to OCMock v2 syntax when working with EarlGrey tests. The modification to andReturn macro allows us to move objects across the process boundary instead of "hiding" an object instead of an NSValue. The "hack" of using NSArray as a tuple could be replaced by a real object, or an NSDictionary, but I went with the simple stupid approach to start.
dmaclach
force-pushed
the
macro_injection
branch
from
a75522e
to
861bfc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a need to inject a replacement for
OCMMacroStatefor when we are doing crossprocess testing using a library like https://github.com/google/EarlGrey/tree/earlgrey2.
See #484.
This simple expansion to the basic macros will give us the flexibility we need to allow
us to use OCMock v3 syntax instead of falling back to OCMock v2 syntax when working
with EarlGrey tests.
The modification to andReturn macro allows us to move objects across the process boundary
instead of "hiding" an object inside of an NSValue. The "hack" of using NSArray as a
tuple could be replaced by a real object, or an NSDictionary, but I went with the simple
stupid approach to start.
This also gets rid of some "undefined behavior" in the previous macro where we were potentially casting a pod type to an id .