Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuba/ssh/server supervision tree lsocket sup #8968

Merged
merged 3 commits into from
Oct 25, 2024
Merged

kuba/ssh/server supervision tree lsocket sup #8968

merged 3 commits into from
Oct 25, 2024

Conversation

u3s
Copy link
Contributor

@u3s u3s commented Oct 21, 2024 •
edited
Loading

overview

  • prototype refactoring ssh server side supervision tree
  • introducing ssh_lsocket_sup and ssh_lsocket modules
  • idea is to always start with preparation of a listen socket
  • not in a user process but by dedicated temporary ssh_lsocket process
  • and start system supervision tree only if previous step succeeded

next steps

  • probably parallel_login refactor could follow this PR
  • as now ssh_acceptor process is simplified
  • and maybe could be created dynamically under existing ssh_acceptor_sup

image

@u3s u3s added the team:PS Assigned to OTP team PS label Oct 21, 2024
@u3s u3s requested a review from IngelaAndin October 21, 2024 14:02
@u3s u3s self-assigned this Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

CT Test Results

    2 files     29 suites   20m 7s ⏱️
  463 tests   459 ✅  4 💤 0 ❌
1 668 runs  1 644 ✅ 24 💤 0 ❌

Results for commit 293f777.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@u3s
ssh: lsocket_sup and lsocket added
3d404e4 
- ssh server side supervision tree update
- listen socket is always 1st step when daemon is started
- listen socket is provided by temporary ssh_lsocket process
- supervised by ssh_lsocket_sup
@u3s
ssh: code reformatted
1af0f84
@u3s u3s force-pushed the kuba/ssh/server_supervision_tree_lsocket_sup branch from a264e68 to 1af0f84 Compare October 21, 2024 15:11
@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Oct 21, 2024
IngelaAndin
IngelaAndin reviewed Oct 22, 2024
View reviewed changes
lib/ssh/src/ssh_lsocket.erl Outdated Show resolved Hide resolved
lib/ssh/src/ssh_lsocket.erl Outdated Show resolved Hide resolved
lib/ssh/src/ssh_lsocket.erl Outdated Show resolved Hide resolved
lib/ssh/src/ssh_lsocket.erl Outdated Show resolved Hide resolved
lib/ssh/src/ssh.erl Outdated Show resolved Hide resolved
@u3s u3s force-pushed the kuba/ssh/server_supervision_tree_lsocket_sup branch 2 times, most recently from 4fa31df to 62d98ae Compare October 24, 2024 16:00
@u3s u3s force-pushed the kuba/ssh/server_supervision_tree_lsocket_sup branch from 62d98ae to 293f777 Compare October 24, 2024 16:44
@IngelaAndin IngelaAndin self-requested a review October 25, 2024 08:50
@u3s u3s merged commit 783478e into erlang:master Oct 25, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IngelaAndin IngelaAndin IngelaAndin approved these changes

Assignees

@u3s u3s

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@u3s @IngelaAndin