erl_eval: Support the fun Name/Arity syntax for creating a fun
#8987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorng
added
team:VM
Attempting to create a fun referering to either an auto-imported
BIF or a local fun defined in shell would fail:
1> fun is_atom/1.
** exception error: undefined function erl_eval:is_atom/1
2> id(I) -> I.
ok
3> fun id/1.
** exception error: undefined function erl_eval:id/1
This commit adds support for defining a fun based on either
an auto-imported BIF:
1> F = fun is_atom/1.
fun erlang:is_atom/1
2> F(a).
true
3> F(42).
false
Or on a local function defined in the shell:
1> I = fun id/1.
#Fun<erl_eval.42.18682967>
2> I(42).
** exception error: undefined shell command id/1
3> id(I) -> I.
ok
4> I(42).
42
As shown in the example, it not necessary that the local fun is
defined at the time the fun is created; only that it is defined when
the fun is called.
Closes erlang#8963
bjorng
force-pushed
the
bjorn/stdlib/erl_eval/GH-8963/OTP-19322
branch
from
2d41b4a
to
79b0e0d
Compare
CT Test Results 2 files 95 suites 1h 9m 20s ⏱️ Results for commit 79b0e0d. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
|
Nice, thanks for fixing that! |
|
I'm not sure if there's some work necessary in the debugger to make it work there as well since it has a (partial?) fork of the evaluator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to create a fun referering to either an auto-imported BIF or a local fun defined in shell would fail:
This pull request adds support for defining a fun based on either an auto-imported BIF:
Or on a local function defined in the shell:
As shown in the example, it not necessary that the local fun is defined at the time the fun is created; only that it is defined when the fun is called.