Marked rebar_utils:find_source/3 as deprecated #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a riskier change to merge in because people in plugins might be relying on |
* introcuded by dec4846 * introcuded to workaround releases prior R20 not having filelib:find_source/3 [1] [1] https://www.erlang.org/doc/apps/stdlib/filelib.html#find_source/3
ariel-anieli
force-pushed
the
filelib_find_source
branch
from
1c5567c
to
bf27f7a
Compare
ariel-anieli
changed the title
|
Here is it, @ferd; thanks for the heads up. |
ferd
approved these changes
Jul 3, 2024
|
Ah I merged quick. Do you think that given the argument types we could have replaced the implementation with the filelib one? So you know, we keep the entry point but no longer own the implementation. |
|
That's true, @ferd; give me some time, I am pushing out a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
filelib:find_source/3.