fix: sourceCode.getScope?.()

eslint-community · Dec 8, 2023 · 48edece · 48edece
1 parent 6d3eb81
commit 48edece
Show file tree

Hide file tree

Showing 12 changed files with 16 additions and 17 deletions.
diff --git a/lib/rules/fixer-return.js b/lib/rules/fixer-return.js
@@ -81,7 +81,7 @@ module.exports = {
         return false;
       }
       const scope =
-        (context.sourceCode || context.getSourceCode())?.getScope(node) ||
+        (context.sourceCode || context.getSourceCode()).getScope?.(node) ||
         context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < 9.0.0
       const staticValue = getStaticValue(node, scope);
       if (!staticValue) {

diff --git a/lib/rules/no-missing-message-ids.js b/lib/rules/no-missing-message-ids.js
@@ -48,6 +48,7 @@ module.exports = {
       },
 
       CallExpression(node) {
+        const scope = sourceCode.getScope?.(node) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < 9.0.0
         // Check for messageId properties used in known calls to context.report();
         if (
           node.callee.type === 'MemberExpression' &&
@@ -80,7 +81,7 @@ module.exports = {
                   val.value,
                   ruleInfo,
                   scopeManager,
-                  sourceCode.getScope(node)
+                  scope
                 )
               )
                 // Couldn't find this messageId in `meta.messages`.

diff --git a/lib/rules/no-missing-placeholders.js b/lib/rules/no-missing-placeholders.js
@@ -48,7 +48,7 @@ module.exports = {
         contextIdentifiers = utils.getContextIdentifiers(scopeManager, ast);
       },
       CallExpression(node) {
-        const scope = sourceCode.getScope(node) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < 9.0.0
+        const scope = sourceCode.getScope?.(node) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < 9.0.0
         if (
           node.callee.type === 'MemberExpression' &&
           contextIdentifiers.has(node.callee.object) &&

diff --git a/lib/rules/no-unused-message-ids.js b/lib/rules/no-unused-message-ids.js
@@ -57,7 +57,7 @@ module.exports = {
           return;
         }
 
-        const scope = sourceCode.getScope(ast);
+        const scope = sourceCode.getScope?.(ast) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < 9.0.0
 
         const messageIdNodesUnused = messageIdNodes.filter(
           (node) => !messageIdsUsed.has(utils.getKeyName(node, scope))

diff --git a/lib/rules/no-unused-placeholders.js b/lib/rules/no-unused-placeholders.js
@@ -47,6 +47,7 @@ module.exports = {
         contextIdentifiers = utils.getContextIdentifiers(scopeManager, ast);
       },
       CallExpression(node) {
+        const scope = sourceCode.getScope?.(node) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < 9.0.0
         if (
           node.callee.type === 'MemberExpression' &&
           contextIdentifiers.has(node.callee.object) &&
@@ -74,7 +75,7 @@ module.exports = {
                   obj.messageId.value,
                   ruleInfo,
                   scopeManager,
-                  sourceCode.getScope(node)
+                  scope
                 );
                 if (correspondingMessage) {
                   obj.message = correspondingMessage.value;
@@ -86,10 +87,7 @@ module.exports = {
           for (const { message, data } of reportMessagesAndDataArray.filter(
             (obj) => obj.message
           )) {
-            const messageStaticValue = getStaticValue(
-              message,
-              sourceCode.getScope(node)
-            );
+            const messageStaticValue = getStaticValue(message, scope);
             if (
               ((message.type === 'Literal' &&
                 typeof message.value === 'string') ||

diff --git a/lib/rules/prefer-message-ids.js b/lib/rules/prefer-message-ids.js
@@ -43,7 +43,7 @@ module.exports = {
 
     return {
       Program(ast) {
-        const scope = sourceCode.getScope(ast) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
+        const scope = sourceCode.getScope?.(ast) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
         contextIdentifiers = utils.getContextIdentifiers(
           sourceCode.scopeManager,
           ast

diff --git a/lib/rules/report-message-format.js b/lib/rules/report-message-format.js
@@ -69,7 +69,7 @@ module.exports = {
 
     return {
       Program(ast) {
-        const scope = sourceCode.getScope(ast) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
+        const scope = sourceCode.getScope?.(ast) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
         contextIdentifiers = utils.getContextIdentifiers(
           sourceCode.scopeManager,
           ast
@@ -97,7 +97,7 @@ module.exports = {
           .forEach((it) => processMessageNode(it, scope));
       },
       CallExpression(node) {
-        const scope = sourceCode.getScope(node) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
+        const scope = sourceCode.getScope?.(node) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
         if (
           node.callee.type === 'MemberExpression' &&
           contextIdentifiers.has(node.callee.object) &&

diff --git a/lib/rules/require-meta-docs-description.js b/lib/rules/require-meta-docs-description.js
@@ -50,7 +50,7 @@ module.exports = {
 
     return {
       Program(ast) {
-        const scope = sourceCode.getScope(ast) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
+        const scope = sourceCode.getScope?.(ast) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
         const { scopeManager } = sourceCode;
 
         const pattern =

diff --git a/lib/rules/require-meta-docs-url.js b/lib/rules/require-meta-docs-url.js
@@ -80,7 +80,7 @@ module.exports = {
 
     return {
       Program(ast) {
-        const scope = sourceCode.getScope(ast) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
+        const scope = sourceCode.getScope?.(ast) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
         const { scopeManager } = sourceCode;
 
         const metaNode = ruleInfo.meta;

diff --git a/lib/rules/require-meta-fixable.js b/lib/rules/require-meta-fixable.js
@@ -77,7 +77,7 @@ module.exports = {
         }
       },
       'Program:exit'(ast) {
-        const scope = sourceCode.getScope(ast) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
+        const scope = sourceCode.getScope?.(ast) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
         const metaFixableProp =
           ruleInfo &&
           utils

diff --git a/lib/rules/require-meta-has-suggestions.js b/lib/rules/require-meta-has-suggestions.js
@@ -44,7 +44,7 @@ module.exports = {
      * @returns {boolean} whether this property should be considered to contain suggestions
      */
     function doesPropertyContainSuggestions(node) {
-      const scope = sourceCode.getScope(node) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
+      const scope = sourceCode.getScope?.(node) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
       const staticValue = getStaticValue(node.value, scope);
       if (
         !staticValue ||

diff --git a/lib/rules/require-meta-type.js b/lib/rules/require-meta-type.js
@@ -46,7 +46,7 @@ module.exports = {
 
     return {
       Program(node) {
-        const scope = sourceCode.getScope(node) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
+        const scope = sourceCode.getScope?.(node) || context.getScope(); // TODO: just use sourceCode.getScope() when we drop support for ESLint < v9.0.0
         const { scopeManager } = sourceCode;
 
         const metaNode = ruleInfo.meta;