Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements as pre-commit-hook #15

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

hfudev
Copy link
Member

@hfudev hfudev commented Oct 3, 2024

HEAD~1

User may now use

  - repo: https://github.com/espressif/cz-plugin-espressif
    rev: fix/pre-commit-entry
    hooks:
      - id: update-changelog

to make changelog generated incrementally


HEAD

User may now install the hook to pre-push stage, and update the changelog before pushing the branch

Copy link

github-actions bot commented Oct 3, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello hfudev, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 26c2a25

@hfudev hfudev changed the title fix: pre-commit entry to support custom args improvements as pre-commit-hook Oct 3, 2024
Copy link
Member

@tomassebestik tomassebestik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hfudev Many thanks for your interest in this project and your contribution.

This makes a lot more sense than running a pre-commit hook on every commit or specific file change.

Left a couple of ideas, but overall it LGTM.

README.md Outdated Show resolved Hide resolved
.pre-commit-hooks.yaml Outdated Show resolved Hide resolved
@hfudev
Copy link
Member Author

hfudev commented Oct 4, 2024

@tomassebestik thanks for your suggestions. PTAL again!

@tomassebestik tomassebestik merged commit 11c2d0a into master Oct 7, 2024
15 checks passed
@tomassebestik tomassebestik deleted the fix/pre-commit-entry branch October 7, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants