fix pr comment rm build flash telemetry (#1328)

espressif · Oct 23, 2024 · f5ecca2 · f5ecca2
1 parent ed521c9
commit f5ecca2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/.github/workflows/pr-comment.yml b/.github/workflows/pr-comment.yml
@@ -49,7 +49,7 @@ jobs:
               return core.error(`No artifacts found`);
             }
             let body = `Download the artifacts for this pull request:\n`;
-            body += `You can test these changes by installing this VSIX by click menu `View` -> `Command Palette...`, type `Install from VSIX` and then select downloaded `esp-idf-extension.vsix` file to install the extension.`;
+            body += `You can test these changes by installing this VSIX by click menu **View** -> **Command Palette...**, type **Install from VSIX** and then select downloaded **esp-idf-extension.vsix** file to install the extension.`;
             for (const art of artifacts) {
               body += `\n* [${art.name}.zip](https://nightly.link/${owner}/${repo}/actions/artifacts/${art.id}.zip)`;
             }

diff --git a/src/build/buildCmd.ts b/src/build/buildCmd.ts
@@ -103,7 +103,9 @@ export async function buildCommand(
     Logger.errorNotify(
       "Something went wrong while trying to build the project",
       error,
-      "buildCommand"
+      "buildCommand",
+      undefined,
+      false
     );
     continueFlag = false;
   }

diff --git a/src/flash/uartFlash.ts b/src/flash/uartFlash.ts
@@ -129,7 +129,13 @@ export async function flashCommand(
     }
     const errStr = `Failed to flash because of some unusual error. Check Terminal for more details`;
     OutputChannel.appendLine(errStr, "Flash");
-    Logger.errorNotify(errStr, error, "flashCommand unknown error");
+    Logger.errorNotify(
+      errStr,
+      error,
+      "flashCommand unknown error",
+      undefined,
+      false
+    );
     continueFlag = false;
   }
   FlashTask.isFlashing = false;