-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance: Enable usage of white spaces in project's path #943
Conversation
Download the artifacts for this pull request: |
Pull request has been marked as |
Hi @AndriiFilippov , Can you re-test again for both of the issues you've found previously? |
@radurentea , This one still persist, but I think we can create separate ticket for this one ? what do you think ? Tested on Linux as well, everything works fine, but on the Extension Configuration finish page I do see this info message: But, this command does not work with spaces in the PATH : I think we should do something with this one. |
@AndriiFilippov Regarding this one:
it doesn't seem to be an issue with current PR, I was not able to reproduce it. |
Also can't build on MacOS.
|
Pull request has been marked as |
Pull request has been marked as |
Pull request has been marked as |
Unfortunately I don't have the time or skill to contribute but I would love to see this merged in the next release! For context, I put both my Here's the build error:
I've tried a few combinations of paths and can't seem to get consistent results unless there are no spaces present in the path, which makes using OneDrive very difficult. I'm using v1.7.0 of this extension. |
New PR for adding support for white spaces can be found here: |
Description
Enable usage of white spaces in project's path.
https://jira.espressif.com:8443/browse/VSC-808
Type of change
Please delete options that are not relevant.
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
With these changes, user should be able to use the VsCode extension and it's features on projects that have white spaces in their path or in the ESP-IDF and ESP-IDF Tools installation paths
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist