[DRAFT] Add someip statistics api to unbound session #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruss
force-pushed
the
add_someip_statistics
branch
from
5982f0c
to
eb9cb6e
Compare
kruss
force-pushed
the
add_someip_statistics
branch
from
eb9cb6e
to
b35e35b
Compare
marcmo
reviewed
Sep 27, 2024
| @@ -58,7 +58,7 @@ | |||
| }, | |||
| "jobs": { | |||
| "regular": { | |||
| "execute_only": [1,2,3,4,5], | |||
There was a problem hiding this comment.
why did this change? does it mean we are not executing those?
marcmo
reviewed
Sep 27, 2024
Comment on lines
+513
to
+517
| if let Some(detail_value) = detail_map.get_mut(&detail_id) { | ||
| *detail_value += 1; | ||
| } else { | ||
| detail_map.insert(detail_id, 1); | ||
| } |
There was a problem hiding this comment.
this is usually done with the entry function (https://doc.rust-lang.org/std/collections/struct.HashMap.html#method.entry)
if possible use that here as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.