Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOOL-91] Add support for MDF #1975

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[TOOL-91] Add support for MDF #1975

wants to merge 1 commit into from

Conversation

kruss
Copy link
Collaborator

@kruss kruss commented Jan 31, 2024

Adds a ByteSource and Parser for MDF and integrates them in a indexer-cli command.

indexer_cli % cargo run --release -- mdf-events example.mf4
handle_mdf_events_subcommand
read: example.mf4
..read took: 2.542366ms
..validate took: 37.174µs
..analyze took: 172.834µs
events:
[0]
 |- ETHERNET : 42198
 |  |- ETH_Frame : 42198
..scan took: 37.515225ms
write: example.mf4_ETHERNET-0.txt
events: 42198
output: 32.658775 MB
..write took: 492.739698ms
overall: 533.145155ms

@kruss kruss changed the title [TOOL-91] Add support for MDF [DRAFT] [TOOL-91] Add support for MDF Jan 31, 2024
@kruss
Copy link
Collaborator Author

kruss commented Jan 31, 2024

MDF repo at https://github.com/esrlabs/mdf needs to become public to fix local cargo dependencies in:

  • application/apps/indexer/parsers/Cargo.toml
  • application/apps/indexer/sources/Cargo.toml
  • application/apps/indexer/indexer_cli/Cargo.toml

marcmo
marcmo reviewed Feb 8, 2024
View reviewed changes
application/apps/indexer/parsers/src/mdf.rs
Comment on lines +35 to +36
unsafe impl<'a> Send for MdfLogMessageParser<'a> {}
unsafe impl<'a> Sync for MdfLogMessageParser<'a> {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is unsafe needed here? we do not need unsafe for any other parsers

@marcmo marcmo marked this pull request as draft September 23, 2024 08:10
@marcmo marcmo changed the title [DRAFT] [TOOL-91] Add support for MDF [TOOL-91] Add support for MDF Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcmo marcmo marcmo left review comments

@DmitryAstafyev DmitryAstafyev Awaiting requested review from DmitryAstafyev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kruss @marcmo