error: direct implementation of `ToString` --> northstar-runtime/src/npk/manifest/mod.rs:201:1 | 201 | / impl ToString for Manifest { 202 | | #[allow(clippy::unwrap_used)] 203 | | fn to_string(&self) -> String { 204 | | // A `Manifest` is convertible to `String` as long as its implementation of `Serialize` does ... | 208 | | } 209 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl

direct implementation of `ToString`: northstar-runtime/src/common/version.rs#L167

error: direct implementation of `ToString` --> northstar-runtime/src/common/version.rs:167:1 | 167 | / impl ToString for VersionReq { 168 | | fn to_string(&self) -> String { 169 | | self.inner.to_string() 170 | | } 171 | | } | |_^ | = help: prefer implementing `Display` instead = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl note: the lint level is defined here --> northstar-runtime/src/lib.rs:5:5 | 5 | clippy::all, | ^^^^^^^^^^^ = note: `#[deny(clippy::to_string_trait_impl)]` implied by `#[deny(clippy::all)]`

Clippy

Clippy had exited with the 101 exit code

Check (stable)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Check (stable)

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Check (stable)

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Check (stable)

Check (stable): northstar-runtime/src/runtime/devicemapper/data_model.rs#L34

associated items `from_slice`, `read_from_prefix`, `from_reader`, and `as_mut_slice` are never used

Check (stable): northstar-runtime/src/runtime/ipc/raw_fd_ext.rs#L6

method `is_nonblocking` is never used

Check (stable)

`northstar-runtime` (lib) generated 2 warnings

Format

Check (1.70.0)

method `is_nonblocking` is never used: northstar-runtime/src/runtime/ipc/raw_fd_ext.rs#L6

warning: method `is_nonblocking` is never used --> northstar-runtime/src/runtime/ipc/raw_fd_ext.rs:6:8 | 4 | pub trait RawFdExt: AsRawFd { | -------- method in this trait 5 | /// Returns true of self is set to non-blocking. 6 | fn is_nonblocking(&self) -> Result<bool>; | ^^^^^^^^^^^^^^

associated items `from_slice`, `read_from_prefix`, `from_reader`, and `as_mut_slice` are never used: northstar-runtime/src/runtime/devicemapper/data_model.rs#L34

warning: associated items `from_slice`, `read_from_prefix`, `from_reader`, and `as_mut_slice` are never used --> northstar-runtime/src/runtime/devicemapper/data_model.rs:34:8 | 25 | pub unsafe trait DataInit: Copy + Send + Sync { | -------- associated items in this trait ... 34 | fn from_slice(data: &[u8]) -> Option<&Self> { | ^^^^^^^^^^ ... 55 | fn read_from_prefix(data: &[u8]) -> Option<Self> { | ^^^^^^^^^^^^^^^^ ... 88 | fn from_reader<R: io::Read>(mut read: R) -> io::Result<Self> { | ^^^^^^^^^^^ ... 118 | fn as_mut_slice(&mut self) -> &mut [u8] { | ^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

Clippy

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Clippy

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Clippy

Documentation

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Documentation

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Documentation