Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Broken Lido DV Exit and Lido validator ejector when a secondery CL client is added to Charon #1950

Merged
merged 8 commits into from
Oct 6, 2024

Conversation

cnupy
Copy link
Contributor

@cnupy cnupy commented Oct 3, 2024

Adding a secondary CL node endpoint to the OBOL_CL_NODE variable breaks the validator-ejector and lido-dv-exit services because they don't support fallback endpoints.

This PR introduces an additional environment variable OBOL_CHARON_CL_ENDPOINTS specific to the Charon service, which should be used to set the CL client for the Charon service. Multiple endpoints can be separated by commas.

default.env Show resolved Hide resolved
default.env Show resolved Hide resolved
@cnupy cnupy requested a review from yorickdowne October 5, 2024 21:25
ethd Outdated Show resolved Hide resolved
ethd Show resolved Hide resolved
Co-authored-by: yorickdowne <[email protected]>
ethd Show resolved Hide resolved
@yorickdowne yorickdowne merged commit 10807a8 into eth-educators:main Oct 6, 2024
17 checks passed
Copy link

gitpoap-bot bot commented Oct 6, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 eth-docker Contributor:

GitPOAP: 2024 eth-docker Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@cnupy cnupy deleted the cnupy/add_charon_cl_env_var branch October 7, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants