fix: remote action inf loop when concurrency is 0 (#55)

* fix: using cache

* fix: remote action in inf loop when concurrency is 0

.github/workflows/release.yml

@@ -14,6 +14,7 @@ jobs:
       - uses: actions/setup-node@v2
         with:
           node-version: "16"
+          cache: "yarn"
       - run: yarn install
       - run: yarn build
       - name: Authenticate with Registry
@@ -51,6 +52,7 @@ jobs:
         with:
           node-version: '16.x'
           registry-url: 'https://npm.pkg.github.com'
+          cache: "yarn"
       - run: yarn
       - run: yarn build
       - run: yarn release --no-verify-access

.github/workflows/test.yml

@@ -15,6 +15,7 @@ jobs:
       - uses: actions/setup-node@v2
         with:
           node-version: "16"
+          cache: "yarn"
       - run: yarn
       - name: Run linters
         uses: wearerequired/lint-action@v1
@@ -30,7 +31,7 @@ jobs:
       - uses: actions/setup-node@v2
         with:
           node-version: "16"
-
+          cache: "yarn"
       - run: yarn install
       - run: yarn build
       - run: yarn coverage
@@ -48,6 +49,7 @@ jobs:
       - uses: actions/setup-node@v2
         with:
           node-version: "16"
+          cache: "yarn"
       - run: yarn install
       - run: yarn build
       - name: Setup git identity

.gitignore

@@ -1,7 +1,6 @@
 node_modules
 .idea
 .DS_Store
-*.lock
 coverage
 *.log
 dist

packages/etd-common/yarn.lock

@@ -0,0 +1,8 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+
+typescript@^4.5.4:
+  version "4.5.4"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.5.4.tgz#a17d3a0263bf5c8723b9c52f43c5084edf13c2e8"
+  integrity sha512-VgYs2A2QIRuGphtzFV7aQJduJ2gyfTljngLzjpfW9FoYZF6xuw1W0vW9ghCKLfcWrCFxK81CSGRAvS1pn4fIUg==

packages/etd-next-js-handlers/yarn.lock

@@ -0,0 +1,8 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+
+typescript@^4.5.4:
+  version "4.5.4"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.5.4.tgz#a17d3a0263bf5c8723b9c52f43c5084edf13c2e8"
+  integrity sha512-VgYs2A2QIRuGphtzFV7aQJduJ2gyfTljngLzjpfW9FoYZF6xuw1W0vW9ghCKLfcWrCFxK81CSGRAvS1pn4fIUg==

packages/etd-remote-action/.gitignore

@@ -6,3 +6,4 @@ yarn.lock
 *.zip
 !jest.config.js
 src/schemas/*.json
+src/main.ts

packages/etd-remote-action/package.json

@@ -31,11 +31,11 @@
     "chalk": "^4.1.1",
     "cli-progress": "^3.9.0",
     "moment": "^2.29.1",
-    "node-ssh": "^12.0.0",
+    "node-ssh": "12.0.4",
     "yaml": "^1.10.2"
   },
   "scripts": {
-    "start": "ts-node src/example.ts",
+    "start": "ts-node src/main.ts",
     "prebuild": "ts-node src/generate.ts",
     "dev": "ts-node-dev --respawn --transpile-only src/index.ts",
     "test": "jest",

packages/etd-remote-action/src/config/config.ts

@@ -135,7 +135,7 @@ export class ConfigParser {
       }
       this.checkAndFixConfig();
       Logger.info("Starting job " + this.config.name);
-      let concurrency = this.config.concurrency ?? 1;
+      let concurrency = Math.max(this.config.concurrency ?? 1, 1);
       // Perform deep copy
       let remoteAddresses: string[] = JSON.parse(
         JSON.stringify(this.config.remote)

packages/etd-remote-action/src/tests/config.test.ts

@@ -13,6 +13,29 @@ jest.mock("node-ssh", () => {
   };
 });
 
+test("Simple test with concurrency 0", async () => {
+  let config = new ConfigParser({ filePath: "/", concurrency: 3 });
+
+  config.config = {
+    logger: undefined,
+    login: { username: "user", password: "pass" },
+    name: "Test",
+    output: false,
+    concurrency: 0,
+    steps: [
+      {
+        name: "My Command",
+        run: "ls",
+      },
+    ],
+    remote: ["1", "2"],
+  };
+
+  let results = await config.runRemoteCommand({});
+  expect(results?.length).toBe(2);
+  expect(results![0][0].type).toBe("command");
+});
+
 test("Simple test with concurrency 1", async () => {
   let config = new ConfigParser({ filePath: "/", concurrency: 3 });