tracing: Show OptimismBaseFeeRecipient in prestate #407
+105
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlb
commented
Oct 21, 2024
Comment on lines
+162
to
+164
| if env.ChainConfig.Optimism != nil { | ||
| t.lookupAccount(params.OptimismBaseFeeRecipient) | ||
| } |
There was a problem hiding this comment.
This is the actual change. Everything else is just for testing.
The OptimismBaseFeeRecipient should show up in prestate tracing results (both the normal prestate and the diff mode prestate results) if IsOptimism. I added one prestate diff test with Optimism turned on to show that it works correctly. This required adding Random (so that IsMerge is true) and L1CostFunc to the test block context.
karlb
force-pushed
the
karlb/tracing-test-optimism-base-fee-recipient
branch
from
f844433
to
4966438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The OptimismBaseFeeRecipient should show up in prestate tracing results (both the normal prestate and the diff mode prestate results) if IsOptimism.
Tests
I added one prestate diff test with Optimism turned on to show that it works correctly. This required adding Random (so that IsMerge is true) and L1CostFunc to the test block context.
I can add a second test for the plain prestate mode if you like.
Additional context
Previous discussion at https://discord.com/channels/1244729134312198194/1282997447609552986