Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): use atomic.Bool instead of int #12368

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 8, 2024

Description

Some solidity files contains multiline comments, so we should first clean them.

Tests

Additional context

Metadata

@jsvisa jsvisa requested a review from a team as a code owner October 8, 2024 11:43
@jsvisa jsvisa requested a review from clabby October 8, 2024 11:43
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.91%. Comparing base (fb7f306) to head (4d97d88).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12368      +/-   ##
===========================================
- Coverage    64.10%   63.91%   -0.19%     
===========================================
  Files           52       52              
  Lines         4312     4312              
===========================================
- Hits          2764     2756       -8     
- Misses        1374     1383       +9     
+ Partials       174      173       -1     
Flag Coverage Δ
cannon-go-tests 63.91% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@jsvisa jsvisa changed the title feat(contracts): rm multiline comments before check unused import feat(contracts): use atomic.Bool instead of int Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant