Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-challenger: Set op-program log level based on the challenger level #12379

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Oct 9, 2024

Description

Set the op-program (host) log level to match op-challenger's log level.

Tests

Updated unit tests, including reworking them to actually assert the value for options rather than just that the option was specified.

@ajsutton ajsutton requested review from a team as code owners October 9, 2024 04:28
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (fb62380) to head (96fe542).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12379      +/-   ##
===========================================
- Coverage    64.32%   64.14%   -0.19%     
===========================================
  Files           52       52              
  Lines         4348     4348              
===========================================
- Hits          2797     2789       -8     
- Misses        1376     1385       +9     
+ Partials       175      174       -1     
Flag Coverage Δ
cannon-go-tests 64.14% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant