Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ct): fix small typo in CONTRIBUTING.md #12393

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Oct 9, 2024

Description

Currently our contributing.md contains some typo issue:

image

The first two should be indented, not align with the list, the third one missing ., then caused the following line directly at the end of this line, no \r\n

Tests

Additional context

Metadata

@jsvisa jsvisa requested a review from a team as a code owner October 9, 2024 15:08
@jsvisa jsvisa requested a review from mds1 October 9, 2024 15:08
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.14%. Comparing base (fb62380) to head (02d4c28).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12393      +/-   ##
===========================================
- Coverage    64.32%   64.14%   -0.19%     
===========================================
  Files           52       52              
  Lines         4348     4348              
===========================================
- Hits          2797     2789       -8     
- Misses        1376     1385       +9     
+ Partials       175      174       -1     
Flag Coverage Δ
cannon-go-tests 64.14% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@jsvisa
Copy link
Contributor Author

jsvisa commented Oct 10, 2024

@smartcontracts could you please take a look at this one, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant