Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batcher refactor: flatten out go routines #12405

Open
wants to merge 7 commits into
base: gk/batcher-cursors-rebased
Choose a base branch
from

Conversation

geoknee
Copy link
Contributor

@geoknee geoknee commented Oct 10, 2024

This is a refactor to try and make the two goroutines spawned by the driver equally clear.

  • Names the previously anonymous receiptsLoop
  • Adds some godoc comments about what each loop does
  • Tries to be a little more idiomatic about passing contexts in to functions

Copy link
Contributor

semgrep-app bot commented Oct 11, 2024

Semgrep found 1 err-todo finding:

  • op-program/client/l2/engineapi/l2_engine_api.go

TODO in error handling code

Ignore this finding from err-todo.

@geoknee geoknee marked this pull request as ready for review October 11, 2024 10:31
@geoknee geoknee requested review from a team as code owners October 11, 2024 10:31
@geoknee geoknee requested review from axelKingsley and removed request for a team October 11, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant