Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-e2e: fix interop tests #12438

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

roberto-bayardo
Copy link
Collaborator

Description

op-e2e/interop tests are currently failing when run in a fresh repo because "make devnet-allocs" isn't generating all the necessary forge artifacts, specifically DeployOPChain.sol. This PR adds the appropriate dependency to generate it.

@roberto-bayardo roberto-bayardo requested a review from a team as a code owner October 12, 2024 18:40
@roberto-bayardo roberto-bayardo force-pushed the fix-e2e-interop-tests branch 2 times, most recently from 30b6afb to 91455c5 Compare October 12, 2024 18:49
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.42%. Comparing base (9d9dc32) to head (5ce0449).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12438      +/-   ##
===========================================
- Coverage    64.60%   64.42%   -0.19%     
===========================================
  Files           52       52              
  Lines         4371     4371              
===========================================
- Hits          2824     2816       -8     
- Misses        1372     1381       +9     
+ Partials       175      174       -1     
Flag Coverage Δ
cannon-go-tests 64.42% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant