Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-5453: Move to Review #6339

Closed
wants to merge 5 commits into from
+5 −5
Closed

Update EIP-5453: Move to Review #6339

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1ea2da
Move EIP-5453 to Review
xinbenlv Jan 16, 2023
4de9dab
Update eip-5453.md
xinbenlv Jan 16, 2023
86482a2
Update eip-5453.md
xinbenlv Jan 16, 2023
e2be85d
Minor grammatical fix
Pandapip1 Jan 18, 2023
515a178
Fix more grammatical errors
Pandapip1 Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions EIPS/eip-5453.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ title: Endorsement - Permit for Any Functions
description: A general protocol for approving function calls in the same transaction rely on EIP-5750.
Pandapip1 marked this conversation as resolved.
Show resolved Hide resolved
author: Zainan Victor Zhou (@xinbenlv)
discussions-to: https://ethereum-magicians.org/t/erc-5453-endorsement-standard/10355
status: Draft
status: Review
type: Standards Track
category: ERC
created: 2022-08-12
Expand All @@ -14,7 +14,7 @@ requires: 165, 712, 1271, 5750
## Abstract

This EIP establish a general protocol for permitting approving function calls in the same transaction rely on [EIP-5750](./eip-5750.md).
Pandapip1 marked this conversation as resolved.
Show resolved Hide resolved
Unlike a few prior art ([EIP-2612](./eip-2612.md) for [EIP-20](./eip-20.md), [EIP-4494](./eip-4494.md) for [EIP-721](./eip-721.md) that
Unlike a few prior art ([EIP-2612](./eip-2612.md) for [EIP-20](./eip-20.md), `EIP-4494` for [EIP-721](./eip-721.md) that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Art? Why have you unlinked EIP-4494?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because EIP-4944 was still a DRAFT. the linter complains if we attempt to move EIP-5453 to REVIEW until 4944 is moved to REVIEW

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. @SamWilsn is it okay to override the bot here?

Also, I still don't get what you mean by art.

Copy link
Contributor

@SamWilsn SamWilsn Mar 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamWilsn is it okay to override the bot here?

I don't believe so. Just don't mention EIP-4494, or move it to the correct stage. If it's important enough to mention, it's important enough to make sure it doesn't change out from under you.

Also, I still don't get what you mean by art.

"Prior Art" is a legal term meaning related work that came before.

usually only permit for a single behavior (`transfer` for EIP-20 and `safeTransferFrom` for EIP-721) and a single approver in two transactions (first a `permit(...)` TX, then a `transfer`-like TX), this EIP provides a way to permit arbitrary behaviors and aggregating multiple approvals from arbitrary number of approvers in the same transaction, allowing for Multi-Sig or Threshold Signing behavior.
Pandapip1 marked this conversation as resolved.
Show resolved Hide resolved

<!-- TODO add context about other EIPs this EIP is designed to work with. -->
Expand Down