Add EIP: NFT Fusing Protocol #6927
Conversation
github-actions
bot
added
c-new
File
|
eth-bot
changed the title
eth-bot
added
e-consensus
github-actions
bot
added
w-ci
|
The commit af6390e (as a parent of 5c69963) contains errors. |
| --- | ||
| eip: 6927 | ||
| title: NFT Fusing Protocol | ||
| description: Fusing multiple NFTs into a new one. |
There was a problem hiding this comment.
Your description doesn't really add any new information that wasn't in the title. How about something like:
| description: Fusing multiple NFTs into a new one. | |
| description: An ERC-721 extension for merging multiple tokens into a combo and later separating them. |
| type: Standards Track | ||
| category: ERC | ||
| created: 2023-04-23 | ||
| requires: 165, 721 |
There was a problem hiding this comment.
You don't mention the use of ERC-165 in your Specification section. You can remove 721 from your requires header, or mention that smart contract conforming to this proposal need to implement ERC165.
|
|
||
| The keywords “MUST,” “MUST NOT,” “REQUIRED,” “SHALL,” “SHALL NOT,” “SHOULD,” “SHOULD NOT,” “RECOMMENDED,” “MAY,” and “OPTIONAL” in this document are to be interpreted as described in RFC 2119. | ||
|
|
||
| **Interface** |
There was a problem hiding this comment.
| **Interface** | |
| ### Interface |
| ## Test Cases | ||
|
|
||
| Test cases should be developed to cover the following scenarios: | ||
|
|
||
| * Minting a valid combo with ERC-721 and/or ERC-1155 NFTs. | ||
| * Dismantling a combo and returning locked NFTs to their owners. | ||
| * Setting combo rules and ensuring compliance during the minting - - process. | ||
| * Approving ERC-721 NFTs for use in combos. | ||
| * Querying combo rules and ingredients. | ||
|
|
||
| ## Reference Implementation | ||
|
|
||
| An implementation of this EIP will be provided upon acceptance of the proposal. | ||
|
|
There was a problem hiding this comment.
| ## Test Cases | |
| Test cases should be developed to cover the following scenarios: | |
| * Minting a valid combo with ERC-721 and/or ERC-1155 NFTs. | |
| * Dismantling a combo and returning locked NFTs to their owners. | |
| * Setting combo rules and ensuring compliance during the minting - - process. | |
| * Approving ERC-721 NFTs for use in combos. | |
| * Querying combo rules and ingredients. | |
| ## Reference Implementation | |
| An implementation of this EIP will be provided upon acceptance of the proposal. | |
| <!-- | |
| ## Test Cases | |
| Test cases should be developed to cover the following scenarios: | |
| * Minting a valid combo with ERC-721 and/or ERC-1155 NFTs. | |
| * Dismantling a combo and returning locked NFTs to their owners. | |
| * Setting combo rules and ensuring compliance during the minting - - process. | |
| * Approving ERC-721 NFTs for use in combos. | |
| * Querying combo rules and ingredients. | |
| ## Reference Implementation | |
| An implementation of this EIP will be provided upon acceptance of the proposal. | |
| --> |
These sections are optional, and if you use an HTML-style comment, the linter will make sure you come back to them before advancing statuses.
| type: Standards Track | ||
| category: ERC | ||
| created: 2023-04-23 | ||
| requires: 165, 721 |
There was a problem hiding this comment.
| requires: 165, 721 | |
| requires: 165, 721, 1155 |
Ingredient.amount doesn't make sense unless you explicitly mention ERC-1155.
| /// @param maxReuseCount Maximum total reuse count of a token from the collection in | ||
| /// this combo collection (only applicable for ERC-721 and when lockTokens is false) | ||
| struct ComboFactor { | ||
| address collectionAddress; |
There was a problem hiding this comment.
You should mention somewhere what standards the collectionAddress is allowed to be. I'm guessing it's ERC-721 and ERC-1155 from your Rationale section?
|
I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually. As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process. If there is relevant history here, please link to this PR from the new pull request. On behalf of the EIP Editors, I apologize for this inconvenience. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: