Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EIP: Offchain checks for ERC-20 distribution #7099

Closed
wants to merge 18 commits into from
Closed

Add EIP: Offchain checks for ERC-20 distribution #7099

wants to merge 18 commits into from

Conversation

civia-code
Copy link

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@civia-code civia-code requested a review from eth-bot as a code owner May 31, 2023 05:58
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-erc labels May 31, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented May 31, 2023 •
edited
Loading

File EIPS/eip-7099.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn, @xinbenlv

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label May 31, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 31, 2023
@civia-code civia-code changed the title Add eip-draft_offchain_checks.md Add EIP: Offchain Checks May 31, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 1, 2023
@civia-code
Copy link
Author

Discussion at https://ethereum-magicians.org/t/eip-7099-off-chain-checks/14526

@eth-bot eth-bot changed the title Add EIP: Offchain Checks Add EIP: Off-chain Checks Jun 6, 2023
@eth-bot eth-bot added the e-review Waiting on editor to review label Jun 6, 2023
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 6, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 6, 2023
@github-actions
Copy link

The commit b2a6dc6 (as a parent of 3c8827c) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jun 12, 2023
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jun 13, 2023
@abcoathup abcoathup mentioned this pull request Jun 22, 2023
Closed
@eth-bot eth-bot changed the title Add EIP: Off-chain Checks Add EIP: Offchain checks for ERC-20 distribution Jul 3, 2023
@civia-code civia-code changed the title Add EIP: Offchain checks for ERC-20 distribution Add EIP: Off-chain checks for ERC-20 distribution Jul 3, 2023
@civia-code civia-code changed the title Add EIP: Off-chain checks for ERC-20 distribution Add EIP: Offchain checks for ERC-20 distribution Jul 3, 2023
lightclient
lightclient requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay, couple nits. Overall this seems very similar to a payment channel though. Is there a reason to standardize this instead of simply using a state channel? Even if not, what is beneficial about standardizing this?

EIPS/eip-7099.md
@@ -0,0 +1,230 @@
---
eip: 7099
title: Offchain checks for ERC-20 distribution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: Offchain checks for ERC-20 distribution
title: Off-chain checks for ERC-20 distribution

EIPS/eip-7099.md

## Abstract

We propose a low cost approach to distribute [ERC-20](./eip-20.md) tokens for high-frequency token issuance use cases such as game rewards, implemented with a one-time deployed Check contract, the off-chain issuing and signing of Checks by the issuers, and batching or bundling of the Checks to mint tokens on-chain by the receivers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentence is a bit of a run on.

EIPS/eip-7099.md

The receivers on the other hand, before minting the tokens on-chain, are assured of the promised tokens with issuers' signatures on the Checks. The receivers accumulate Checks to mint in batch or bundle to save gas, and have the option to mint at a low gas time period.

## Backwards Compatibility
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Backwards Compatibility

Section is optional, no need to include if nothing relevant is in the section.

@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abcoathup abcoathup abcoathup left review comments

@lightclient lightclient lightclient requested changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-erc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@civia-code @eth-bot @SamWilsn @lightclient @abcoathup @mtsquant