Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: manifest v3 #93

Closed
wants to merge 7 commits into from
Closed

chore: manifest v3 #93

wants to merge 7 commits into from

Conversation

tomicvladan
Copy link
Collaborator

Updated manifest.json to be v3 compatible. And made necessary changes to support new v3 extension API.

* chore: update manifest.json file to v3

* chore: ajdust http interceptors
* Adjust DappSessionManager to work correctly in service_worker

* Fix lint errors
@nugaon nugaon changed the title Chore/manifest v3 chore: manifest v3 Feb 7, 2022
@vojtechsimetka
Copy link
Contributor

So the code looks good to me, but the tests do fail locally as well. I've noticed that the BZZ protocol does not work well which may affect other tests as well.
Screenshot 2022-02-08 at 9 13 46

@tomicvladan
Copy link
Collaborator Author

That's correct, the bzz:// protocol is not working in tests. But if you copy that link and try it from normal browser it will work.

The only error that is repeating all the time is this:
Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-2uHX9ok3UCcIAhV0M5q9/gYaxeNt7RqvmUafEXKmTR0='), or a nonce ('nonce-...') is required to enable inline execution.

@vojtechsimetka
Copy link
Contributor

Any idea how can we fix the tests?

@agazso also told me it does not work if the default search is not "google" (it was always like this). Any idea if this can be improved?

@agazso
Copy link
Member

agazso commented Feb 9, 2022

@agazso also told me it does not work if the default search is not "google" (it was always like this). Any idea if this can be improved?

Regarding this I opened an issue #94
This is what the IPFS companion does: ipfs/ipfs-companion#164 (comment)

@tomicvladan tomicvladan deleted the chore/manifest-v3 branch September 16, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants