Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paymaster Updates #15

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Paymaster Updates #15

merged 3 commits into from
Aug 21, 2023

Conversation

vignesha22
Copy link
Contributor

Description

  • Changed a few options for getting paymaster url and context on init prime SDK
  • Changed the response of paymaster type to suit Arka

Motivation and Context

  • Code for adding a paymaster on previous versions was unreachable code or was only possible locally

How Has This Been Tested?

  • Tested Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

ch4r10t33r
ch4r10t33r approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding tests in the next iteration.

@vignesha22 vignesha22 merged commit 344aa4f into master Aug 21, 2023
2 checks passed
@arddluma arddluma deleted the Paymaster_updates branch November 1, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbw33 lbw33 lbw33 approved these changes

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vignesha22 @ch4r10t33r @lbw33