Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Network #74

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Custom Network #74

merged 2 commits into from
Nov 22, 2023

Conversation

vignesha22
Copy link
Contributor

Description

  • Removed UnsupportedChainId error

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

Copy link

linear bot commented Nov 22, 2023

PRO-1990 Unsupported chain error

Description:

When an unsupported chain ID is passed into the Etherspot Prime SDK, it should throw an error that can be caught. Right now the library throws a error that offers no information to the user into why they made a mistake.

Pre-requisites:

  • N/A

Requirements:

  • Rework the initialisation constructor to check first if the chain ID exists in our supported chains array
    • If it does not, throw an error with a helpful error message and a link to our documentation which shows our supported chains.

Resources:

User stories:

  • Success stories
    • When a developer enters a wrong or unsupported chain ID, the SDK should throw an error that is helpful

Specific Acceptance Criteria:

  • As per the user stories above.

Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@0xSulpiride 0xSulpiride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@arddluma arddluma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would it be possible to have an example code on how to instantiate Prime SDK with custom network?

@vignesha22 vignesha22 merged commit c2813c9 into master Nov 22, 2023
3 of 4 checks passed
@vignesha22 vignesha22 deleted the PRO-1990-Custom_Network branch November 22, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported network error when initializing custom chain in Prime SDK [BUG]
4 participants