Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-2029 - PrimeSDK Code Refactor #90

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

vignesha22
Copy link
Contributor

Description

  • Changed the data service to initialise as a seperate entity independent of the primeSdk object
  • Removed unnecessary state variables and changed the walletAddress variable name to EOAAddress for better understanding
  • Optimised the fetching of accountAddress since before it was fetching from on chain for every request to getCounterFactualAddress from the rpc, now it stores the account address locally in the initialised PrimeSDK object
  • Fixed network state variable to output the network which it is connected to

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

Copy link

linear bot commented Dec 22, 2023

@vignesha22 vignesha22 merged commit 10e81f0 into master Jan 8, 2024
5 of 6 checks passed
@vignesha22 vignesha22 deleted the PRO-2029-Code_Refactor branch January 8, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants