Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose prebuilt package #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

harshjv
Copy link

@harshjv harshjv commented May 6, 2017

Exposing prebuilt package so it can be used without babel in other projects. (or at least without a global transform)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling ef23f8c on harshjv:expose-prebuilt-package into a76d479 on ethjs:master.

@SilentCicero
Copy link
Member

You could just import the dist file like so:

const ethUtil = require('ethjs-util/dist/ethjs-util.js');

@harshjv
Copy link
Author

harshjv commented May 8, 2017

Ya, but that will only work if someone writes ethjs-util/dist/ethjs-util.js instead of ethjs-util which isn't a case with many open source projects using this package.

Cheers.

@SilentCicero
Copy link
Member

SilentCicero commented May 12, 2017

I can adjust the code to fix the use of module exports/global etc. I think that would be a better approach. I dont want to ship the minified or build as the main package as I already ship an ES5 build.

So your saying your having trouble using this with webpack? Where and how, could you expand? Sorry, been busy on other projects. But I think we can safe wrap module, so that is nicely exports to global if available.

I have no trouble using this module with webpack though, so I dont see where the trouble area is coming from. This module is published in ES5 common JS code, so it should work with webpack/nodejs out of the box.

It's constructued in ES6, but shipped in NPM in ES6 common JS compliance.

@harshjv

legobeat added a commit to legobeat/ethjs-util that referenced this pull request Dec 15, 2022
deprecate nodejs < v8.17, npm < v6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants