Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in Synths #260

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/whitepaper.md
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ In essence, a liquidation is equivalent to a stop-loss order. As long as you set

**This section is still a work-in-progress and is subject to change**

Since the EVK is a *kit*, it attempts to be maximally flexible and doesn't enforce policy decisions on vault creators. This means that it is possible to create vaults with insecure or malicious configurations. Furthermore, an otherwise secure vault may be insecure because it accapts an [insecure collateral as collateral](#untrusted-collaterals) (or a collateral vault itself accepts insecure collateral, etc, recursively).
Since the EVK is a *kit*, it attempts to be maximally flexible and doesn't enforce policy decisions on vault creators. This means that it is possible to create vaults with insecure or malicious configurations. Furthermore, an otherwise secure vault may be insecure because it accepts an [insecure collateral as collateral](#untrusted-collaterals) (or a collateral vault itself accepts insecure collateral, etc, recursively).

Perspectives provide a mechanism for validating properties of a vault using on-chain verifiable logic. A perspective is any contract that implements the following interface:

Expand Down
8 changes: 4 additions & 4 deletions src/Synths/ERC20Collateral.sol
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ abstract contract ERC20Collateral is EVCUtil, ERC20Permit, ReentrancyGuard {
{}

/// @notice Transfers a certain amount of tokens to a recipient.
/// @dev Overriden to add reentrancy protection.
/// @dev Overridden to add reentrancy protection.
/// @param to The recipient of the transfer.
/// @param amount The amount shares to transfer.
/// @return A boolean indicating whether the transfer was successful.
Expand All @@ -29,7 +29,7 @@ abstract contract ERC20Collateral is EVCUtil, ERC20Permit, ReentrancyGuard {
}

/// @notice Transfers a certain amount of tokens from a sender to a recipient.
/// @dev Overriden to add reentrancy protection.
/// @dev Overridden to add reentrancy protection.
/// @param from The sender of the transfer.
/// @param to The recipient of the transfer.
/// @param amount The amount of shares to transfer.
Expand All @@ -47,7 +47,7 @@ abstract contract ERC20Collateral is EVCUtil, ERC20Permit, ReentrancyGuard {
/// @notice Transfers a `value` amount of tokens from `from` to `to`, or alternatively mints (or burns) if `from`
/// (or `to`) is the zero address. All customizations to transfers, mints, and burns should be done by overriding
/// this function.
/// @dev Overriden to require account status checks on transfers from non-zero addresses. The account status check
/// @dev Overridden to require account status checks on transfers from non-zero addresses. The account status check
/// must be required on any operation that reduces user's balance. Note that the user balance cannot be modified
// outside of this function as the account status check must always be requested after the balance is modified which
// is ensured by this function. If any user balance modifications are done outside of this function, the contract
Expand All @@ -64,7 +64,7 @@ abstract contract ERC20Collateral is EVCUtil, ERC20Permit, ReentrancyGuard {
}

/// @notice Retrieves the message sender in the context of the EVC.
/// @dev Overriden due to the conflict with the Context definition.
/// @dev Overridden due to the conflict with the Context definition.
/// @dev This function returns the account on behalf of which the current operation is being performed, which is
/// either msg.sender or the account authenticated by the EVC.
/// @return The address of the message sender.
Expand Down
4 changes: 2 additions & 2 deletions src/Synths/ESynth.sol
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ contract ESynth is ERC20Collateral, Ownable {
}

/// @notice Retrieves the message sender in the context of the EVC.
/// @dev Overriden due to the conflict with the Context definition.
/// @dev Overridden due to the conflict with the Context definition.
/// @dev This function returns the account on behalf of which the current operation is being performed, which is
/// either msg.sender or the account authenticated by the EVC.
/// @return The address of the message sender.
Expand Down Expand Up @@ -155,7 +155,7 @@ contract ESynth is ERC20Collateral, Ownable {
}

/// @notice Retrieves the total supply of the token.
/// @dev Overriden to exclude the ignored accounts from the total supply.
/// @dev Overridden to exclude the ignored accounts from the total supply.
/// @return The total supply of the token.
function totalSupply() public view override returns (uint256) {
uint256 total = super.totalSupply();
Expand Down