add public getters for module addresses #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoytech
reviewed
Mar 20, 2024
src/EVault/modules/Dispatch.sol
Outdated
There was a problem hiding this comment.
Is Dispatch actually a module? Should it live in the modules/ dir?
There was a problem hiding this comment.
It is handling the modules. But you're right, i've been thinking about it. It doesn't really fit into any other folder though. Move it to /shared?
There was a problem hiding this comment.
Or put it alongside EVault.
There was a problem hiding this comment.
I would say alongside? Personally I would probably move everything from shared to top-level, but I'm not bothered either way.
There was a problem hiding this comment.
I think it's cleaner with just a few top level contracts, so I'd keep shared separate
hoytech
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.