Test: basic liquidation tests #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haythem Sellami <[email protected]>
haythemsellami
changed the title
dglowinski
reviewed
Mar 29, 2024
dglowinski
reviewed
Mar 29, 2024
dglowinski
reviewed
Mar 29, 2024
| import "src/EVault/shared/types/Types.sol"; | ||
| import "src/EVault/shared/Constants.sol"; | ||
|
|
||
| contract VaultTest_Liquidation is EVaultTestBase { |
There was a problem hiding this comment.
The tests are a bit unstructured right now, but overall idea is to match the folder and file structure with the contracts tested. So in this case, as the module tested is liquidation, it would be `/evault/modules/Liquidation.t.sol"
There was a problem hiding this comment.
correction: /evault/modules/Liquidation/Liquidation.t.sol
There was a problem hiding this comment.
Okay I moved it, let's merge this one and I will start porting old tests.
There was a problem hiding this comment.
what about the other comments?
There was a problem hiding this comment.
All comments should be addressed now.
dglowinski
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic liquidation unit tests.