comment on down-cast, add validations #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Synths/ESynth.sol
Outdated
| @@ -44,11 +44,14 @@ contract ESynth is ERC20Collateral, Ownable { | |||
| address sender = _msgSender(); | |||
| MinterData storage minterCache = minters[sender]; | |||
|
|
|||
| if (minterCache.capacity < uint256(minterCache.minted) + amount) { | |||
| if ( | |||
| amount > type(uint256).max - minterCache.minted | |||
There was a problem hiding this comment.
not amount > type(uint128).max - minterCache.minted as we agreed?
There was a problem hiding this comment.
oh, I thought you meant to make the argument in the function to be 128. Cool pushing a fix
There was a problem hiding this comment.
the arg type cannot change. it wouldn't be compatible with the CCIP anymore if it did
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.