Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I added a few filters #25

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

I added a few filters #25

wants to merge 6 commits into from

Conversation

hexapode
Copy link

  • Color
  • Color Adjust
  • Exposure
  • Gamma
  • GammaRGB (simillar to SVG Gamma implementation)
  • Hue
  • Softcontrast
  • Color invert
  • mirror
  • sobel

@jaswdr
Copy link

jaswdr commented Sep 16, 2015

+1

@amilajack
Copy link

@evanw This would be a great addition! What is the status of this PR?

@jywarren
Copy link

I love this too, awesome! Curious if there's a good place to look in here for how filters are added, and how I (or someone who knows WebGL better) might go about adapting a barrel distortion (lens distortion) filter from another implementation into glfx.js: #38

@aghouseh
Copy link

+1

@joedf
Copy link

joedf commented Nov 7, 2019

Great work! 👍 However, I would remove the console.log(arguments); statement in the sobel filter that you probably used for debugging. 😉

I am having trouble getting this to work, my canvas is simply black.

Remove debug statment
@hexapode
Copy link
Author

hexapode commented Nov 7, 2019

Great work! 👍 However, I would remove the console.log(arguments); statement in the sobel filter that you probably used for debugging. 😉

I am having trouble getting this to work, my canvas is simply black.

Nice catch.

@joedf
Copy link

joedf commented Nov 7, 2019

Cool! I've pulled your changes in and updated the repo to include the newer fix to get it working again. 👍

Any users that want a working build of this without going through this trouble can get it here:

@@ -0,0 +1,44 @@
/**
* @filter GammaRGB
* @description Full controll of image Gamma similar to SVG feComponentTransferElement Gamma implementation
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've notice a minor typo :b controll -> control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants