Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bower.json, package.json, and dist/glfx.js #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jywarren
Copy link

For submitting to npm and bower. I plan to submit these myself, but can wait if you'd like to instead. Great library, thanks!

@jywarren
Copy link
Author

Hi, just checking if you'd be willing to pull this in -- it would make it much easier to include this excellent work in other modules! Thanks!

@@ -0,0 +1,20 @@
{
"name": "glfx-js",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be named glfx, as that is what is now published on npm.

@tbranyen
Copy link

tbranyen commented Dec 8, 2016

I went ahead and published on npm under [email protected]. If you want access as well @jywarren I can add you. @evanw any chance you could add us as collabs to the project? Would be happy to get this in a better state for reuse.

@tbranyen
Copy link

tbranyen commented Dec 8, 2016

I got too eager and accidentally deleted the "main" line in 0.0.1, added that back in 0.0.2. If we can get this merged, I'll open a PR that adjusts the package.json.

@jywarren
Copy link
Author

jywarren commented Dec 8, 2016 via email

@tbranyen
Copy link

tbranyen commented Dec 8, 2016

@jywarren I was able to get the module working w/ ES/CJS/global so you can do this now:

npm install [email protected]

ES Modules:

import fx from 'gflx';

CJS:

const { canvas } = require('fx');

Global:

<script src="node_modules/glfx/glfx.js"></script>
<script>
  const canvas = window.fx.canvas():
</script>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants