-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added bower.json, package.json, and dist/glfx.js #31
base: master
Are you sure you want to change the base?
Conversation
e329c0e
to
07a117c
Compare
Hi, just checking if you'd be willing to pull this in -- it would make it much easier to include this excellent work in other modules! Thanks! |
@@ -0,0 +1,20 @@ | |||
{ | |||
"name": "glfx-js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be named glfx, as that is what is now published on npm.
I went ahead and published on npm under [email protected]. If you want access as well @jywarren I can add you. @evanw any chance you could add us as collabs to the project? Would be happy to get this in a better state for reuse. |
I got too eager and accidentally deleted the "main" line in 0.0.1, added that back in 0.0.2. If we can get this merged, I'll open a PR that adjusts the package.json. |
hmm, sure, happy to be added, though not sure there's much else I have to
offer. Thanks!
…On Thu, Dec 8, 2016 at 12:02 PM, Tim Branyen ***@***.***> wrote:
I got too eager and accidentally deleted the "main" line in 0.0.1, added
that back in 0.0.2. If we can get this merged, I'll open a PR that adjusts
the package.json.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABfJzjtDbS5iorxjHUf3mL6IWun4c3qks5rGDgmgaJpZM4H0tpa>
.
|
@jywarren I was able to get the module working w/ ES/CJS/global so you can do this now:
ES Modules: import fx from 'gflx'; CJS: const { canvas } = require('fx'); Global: <script src="node_modules/glfx/glfx.js"></script>
<script>
const canvas = window.fx.canvas():
</script> |
For submitting to npm and bower. I plan to submit these myself, but can wait if you'd like to instead. Great library, thanks!