Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Discharge-Mode for goodwe-hybrid #16649

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

maatinh
Copy link
Contributor

@maatinh maatinh commented Oct 14, 2024

Previously used Mode 8 is putting battery into standby where it would not charge or discharge. Mode 2 uses all PV-Power to charge Battery and uses Grid-Power to power AC side. Discharging is prevented.

Previously used Mode 8 is putting battery into standby where it would not charge or discharge.
Mode 2 uses all PV-Power to charge Battery and uses Grid-Power to power AC side. Discharging is prevented.
@andig
Copy link
Member

andig commented Oct 14, 2024

/cc @andiwist

@andig andig added the devices Specific device support label Oct 14, 2024
@andiwist
Copy link
Contributor

Let me try out this change also on my setup here. My previous changes were based on little knowledge. Therefore I appreciate proposals.

@maatinh
Copy link
Contributor Author

maatinh commented Oct 15, 2024

Let me try out this change also on my setup here. My previous changes were based on little knowledge. Therefore I appreciate proposals.

You may want to refer to this doc I used to implement and test the settings:

#12752 (comment)

@andiwist
Copy link
Contributor

@maatinh Could you please provide me a binary of evcc with the changes please (win or linux x86)? It seems I didn't backup my evcc development environment and not much time to setup a new one now.

@maatinh
Copy link
Contributor Author

maatinh commented Oct 15, 2024

@maatinh Could you please provide me a binary of evcc with the changes please (win or linux x86)? It seems I didn't backup my evcc development environment and not much time to setup a new one now.

I‘m running the nightly build in docker. Will check tmo to copy the binary from there for you.

@andiwist
Copy link
Contributor

andiwist commented Oct 16, 2024

Meanwhile I tested the modes using NodeRed:

Test1: PowerMode 1, PowerSet 0 PV 7-8kw, Bat 100%, Car FastCharge 11kw -> 7,8 kw from PV, 3,6 kw from Bat
Test2: PowerMode 2, PowerSet 0, PV 7-8kw, Bat 100%, Car FastCharge 11kw -> 7,8 kw from PV, 3,6 kw from Grid
Test3: PowerMode 8, PowerSet 0, PV 7-8kw, Bat 100%, Car FastCharge 11kw -> 7,8 kw from PV, 3,6 kw from Grid

Test4: PowerMode 1, PowerSet 0 PV 7-8kw, Bat 96%, Car FastCharge 5,4kw -> 5,4 kw from PV to car , 1,6 kw to Bat
Test5: PowerMode 2, PowerSet 0 PV 7-8kw, Bat 96%, Car FastCharge 5,4kw -> 5,4 kw from PV to car , 1,6 kw to Bat
Test6: PowerMode 8, PowerSet 0, PV 7-8kw, Bat 96%, Car FastCharge 5,4kw -> 5,4 kw from PV, 1,6 kw to Grid

Looks like Mode 2 is a better fit than 8 for cases where enough PV power is available to charge the. car and the battery

@andig
Copy link
Member

andig commented Oct 16, 2024

So... good to go?

@andiwist
Copy link
Contributor

The change is very trivial, but my tests were done using NodeRed. So if possible I would like to repeat the test at least once using the Evcc SW containing the change. I might find tonight some time to set up a new development environment to create a new binary for myself. Or that nightly mentioned above?

@andig andig merged commit a0b40c1 into evcc-io:master Oct 16, 2024
6 checks passed
@andig
Copy link
Member

andig commented Oct 16, 2024

You can test in tomorrow's nightly. Worst case we revert.

@andiwist
Copy link
Contributor

Looks good also in the evcc nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devices Specific device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants