Fixes queue handling for eveapi jobs (#381)

* Don't override default value for queue in constructor and set other queue for notifications. * Move queue comment to correct line.
eveseat · Dec 24, 2023 · 4e39dca · 4e39dca
1 parent 1206e78
commit 4e39dca
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/Jobs/Character/Notifications.php b/src/Jobs/Character/Notifications.php
@@ -33,6 +33,8 @@
  */
 class Notifications extends AbstractAuthCharacterJob
 {
+    public $queue = 'notifications';
+
     /**
      * @var string
      */

diff --git a/src/Jobs/EsiBase.php b/src/Jobs/EsiBase.php
@@ -73,7 +73,7 @@ abstract class EsiBase extends AbstractJob
     /**
      * @var string By default, queue all ESI jobs on public queue.
      */
-    public $queue = 'public';
+    public $queue = 'public'; // By default, queue all ESI jobs on public queue.
 
     /**
      * @var int By default, retry all ESI jobs 3 times.
@@ -154,9 +154,6 @@ abstract class EsiBase extends AbstractJob
      */
     public function __construct()
     {
-        // By default, queue all ESI jobs on public queue.
-        $this->queue = 'public';
-
         // Attach an ESI Client.
         $this->esi = app()->make(EsiClient::class);
     }