Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scalafmt #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreisilviudragnea
Copy link
Contributor

@andreisilviudragnea andreisilviudragnea commented Apr 7, 2022

  • Run Scalafmt in validateOnly mode when building
  • Use Scalafmt defaults

Fixes #29.

- Run Scalafmt in validateOnly mode when building
- Use Scalafmt defaults
Comment on lines +217 to +223
<validateOnly>true</validateOnly>
<configLocation>.scalafmt.conf</configLocation>
</configuration>
<executions>
<execution>
<goals>
<goal>format</goal>
Copy link
Owner

@evis evis Apr 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues here:

  1. can't simply run mvn scalafmt:format in order to format code locally;
  2. can't compile unformatted files.

I suggest to remove validateOnly and don't run scalafmt on format goal. Instead, we should check formatting on CI using github action, similar to https://github.com/evis/scalafix-maven-plugin/blob/master/.github/workflows/scalafix.yml.

This way, the issues will be solved, and formatting will still be checked on CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add scalafmt CI check
2 participants