Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add lock for parallel tests #150

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

yyq1025
Copy link

@yyq1025 yyq1025 commented Aug 1, 2022

Hi maintainers,

This is a really good template and I'm using it in my project, but I find the test file here does not run tests in parallel correctly. Mock's EXPECTs are very likely to have a conflict when there are many (like 10) tests running concurrently. This issue could be easily reproduced by copying test cases 10 times and then running tests 10 times. You will be very likely to see there are 1 or 2 test cases that failed. Therefore, I add a lock here to avoid conflicts.

Thanks

@yyq1025
Copy link
Author

yyq1025 commented Aug 2, 2022

Also, we could just delete these two lines of code to avoid the concurrent issue.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant