Feat: Make Excon instance to accept ciphers SSL option (#45)
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
olleolleolle
reviewed
Sep 8, 2024
lib/faraday/excon/version.rb
Outdated
| @@ -2,6 +2,6 @@ | |||
|
|
|||
| module Faraday | |||
| module Excon | |||
| VERSION = '2.1.0' | |||
| VERSION = '2.2.0' | |||
There was a problem hiding this comment.
I think perhaps the release process does the version upgrade of this library, best keep that out of the PR.
There was a problem hiding this comment.
Yep, thanks for letting them know about that.
saiqulhaq
force-pushed
the
feat/ciphers-opt-support
branch
from
5715811
to
06da6fd
Compare
saiqulhaq
force-pushed
the
feat/ciphers-opt-support
branch
from
06da6fd
to
baffa5b
Compare
|
Thanks for the feedback @olleolleolle I just updated the Faraday dependency to be more permissive. |
|
@saiqulhaq Great! Now, let's see what the maintainers of this repo say. I recommend a merge! |
|
LGTM, thanks! |
|
Does this need a release? |
|
@geemus Well, I don’t think anybody’s waiting for precisely this, but it’s a nice feature. Take it in your time. |
|
Released in v2.2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to support ciphers SSL Option usage as mentioned in this PR lostisland/faraday#1586