Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gallery build #1083

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Fix gallery build #1083

merged 4 commits into from
Nov 28, 2023

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Sep 29, 2023 •
edited
Loading

A particular resource is now private, and must be removed.

@agoose77 agoose77 marked this pull request as ready for review September 29, 2023 11:32
@agoose77 agoose77 requested a review from choldgraf September 29, 2023 11:32
@agoose77 agoose77 changed the title fix: drop https://docs.datapartnership.org Fix gallery build Sep 29, 2023
@rowanc1
Copy link
Member

rowanc1 commented Nov 3, 2023

This looks good @agoose77, and should add for some of the other gallery PRs come in: #1098

rowanc1
rowanc1 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@rowanc1 rowanc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔗🚀

@rowanc1
Copy link
Member

rowanc1 commented Nov 3, 2023

Not quite sure how to fix RTD.

@agoose77
Copy link
Contributor Author

agoose77 commented Nov 3, 2023

I'll be able to look at that this weekend

choldgraf
choldgraf approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@choldgraf choldgraf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

The broken RTD build is because we have an outdated configuration structure. We need to add an os.build config. Not related to this PR

@choldgraf choldgraf enabled auto-merge (squash) November 28, 2023 23:48
@choldgraf choldgraf disabled auto-merge November 28, 2023 23:49
@choldgraf choldgraf merged commit c54c9b3 into main Nov 28, 2023
1 of 2 checks passed
@choldgraf
Copy link
Member

@agoose77 in the future please just self-merge these!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

@rowanc1 rowanc1 rowanc1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agoose77 @rowanc1 @choldgraf