feat: Add videoconferencing space settings - EXO-68457 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdenarie
requested changes
Feb 9, 2024
exo-swf
force-pushed
the
feature/maintenance
branch
from
1bca3e0
to
8bfa8d3
Compare
IlhemEssaadi
force-pushed
the
task/68457
branch
2 times, most recently
from
2d02921
to
f286172
Compare
rdenarie
previously approved these changes
Feb 13, 2024
| @Override | ||
| public List<ActiveProviderInfo> getActiveProvidersForSpace(String spaceId) { | ||
| List<ExternalVisioConnector> externalVisioConnectors = externalVisioConnectorService.getActiveExternalVisioConnectorsForSpace(); | ||
|
|
There was a problem hiding this comment.
One thing is missing here :
for each externalVisioConnector, you need to get the associated setting for the current space
IlhemEssaadi
force-pushed
the
task/68457
branch
from
f286172
to
b6c7efb
Compare
rdenarie
approved these changes
Feb 14, 2024
IlhemEssaadi
added a commit
that referenced
this pull request
Mar 4, 2024
IlhemEssaadi
added a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.