Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump minimum required Node version to 18.13.0 #2420

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

byCedric
Copy link
Member

Why

This version includes the File primitive that might be required for FormData and large file uploads.

See: https://nodejs.org/en/blog/release/v18.13.0#introduce-file
See: #2414 (comment)

How

Bumped all engines: node: >=18.0.0 to engines: node: >=18.13.0

Test Plan

Only a package change.

Copy link

❌ It looks like a changelog entry is missing for this PR. You have two options: you can add it manually, or you can use the changelog bot to do it for you.
🤖 To use the bot, simply comment on this PR with the command /changelog-entry [breaking-change|new-feature|bug-fix|chore] [message].
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link

Size Change: -1.85 kB (0%)

Total Size: 52 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52 MB -1.85 kB (0%)

compressed-size-action

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (3817e2d) to head (fc227c4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2420   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files         530      530           
  Lines       19509    19509           
  Branches     3968     3968           
=======================================
  Hits        10427    10427           
  Misses       8330     8330           
  Partials      752      752           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@szdziedzic szdziedzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

I believe we will need to add the breaking change changelog entry again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants