Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds workflow:validate command #2650

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonsamp
Copy link
Member

@jonsamp jonsamp commented Oct 24, 2024

Why

This adds a command to validate YAML in workflow configuration files.

Screenshots

Valid YAML output

Screenshot 2024-10-24 at 12 04 22 AM

Invalid YAML output

Screenshot 2024-10-24 at 12 04 28 AM

Test Plan

Create a .yml file and test it with eas workflow:validate path/to/file.yml. You should see output like the screenshots above.

  • Make sure non existent files result in an error
  • Make sure non .yml/.yaml files result in an error
  • Make sure bad YAML results in an error
  • Make sure good YAML results in no error

Copy link

linear bot commented Oct 24, 2024

@jonsamp jonsamp force-pushed the jon/eng-13772-create-workflows-eas-cli-command branch from dbbf05e to 1706240 Compare October 24, 2024 05:31
Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link

Size Change: -488 kB (-0.92%)

Total Size: 52.5 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.5 MB -488 kB (-0.92%)

compressed-size-action

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 30 lines in your changes missing coverage. Please review.

Project coverage is 52.96%. Comparing base (a212662) to head (5633e1e).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/workflow/validate.ts 23.08% 30 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2650      +/-   ##
==========================================
- Coverage   53.01%   52.96%   -0.05%     
==========================================
  Files         567      568       +1     
  Lines       21647    21686      +39     
  Branches     4242     4247       +5     
==========================================
+ Hits        11474    11483       +9     
- Misses      10143    10173      +30     
  Partials       30       30              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant