Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Semantic Versioning #36

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Conversation

marmoure
Copy link
Contributor

@marmoure marmoure commented Nov 6, 2023

This PR depends on #35
Switch to 1.1.0-SNAPSHOT instead of 1.1-SNAPSHOT which matches all the other version numbers we are using.

@adamretter adamretter changed the title [Fix] use semantic versioning Use semantic versioning Nov 6, 2023
@adamretter adamretter changed the title Use semantic versioning Use Semantic Versioning Nov 6, 2023
@marmoure marmoure force-pushed the fix/version branch 2 times, most recently from a221ab2 to 2db188c Compare November 8, 2023 12:03
@adamretter
Copy link
Member

@marmoure Please can you also update the README.md file with the correct version number as part of this PR

@marmoure
Copy link
Contributor Author

marmoure commented Nov 8, 2023

@adamretter should we switch to x.x.x style of version number

README.md Outdated
@@ -16,7 +16,7 @@ The [compiled artifact](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22com.ev
<dependency>
<groupId>com.evolvedbinary.cql</groupId>
<artifactId>corpusql-parser</artifactId>
<version>1.0</version>
<version>1.1-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 1.1.0-SNAPSHOT!

Copy link
Member

@adamretter adamretter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version number needs fixing

@marmoure
Copy link
Contributor Author

marmoure commented Nov 8, 2023

@adamretter it was a wong commit from my laptop
i fixed it now

@adamretter adamretter merged commit e2fe3eb into exquery:master Nov 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants