feat: add discord link to end, minor tweaks to verbiage #35
Conversation
README.md
Outdated
| @@ -18,7 +18,7 @@ Add the library from [crates.io](https://crates.io/crates/extism-pdk). | |||
| cargo add extism-pdk | |||
| ``` | |||
|
|
|||
| Change your `Cargo.toml` to set the crate-type to `cdylib`: | |||
| Change your `Cargo.toml` to set the crate-type to `cdylib` (this instructs the compiler to produce a Wasm file): | |||
There was a problem hiding this comment.
This isn't exactly accurate. Compiling to a wasm32-* target is what makes the output a wasm file. This tells the compiler that you are emitting a dynamic library and not an executable (which in wasm parlance means a command pattern module with a _start function)
There was a problem hiding this comment.
Oh yeah I can see how that would be misleading. I meant as opposed to a .dylib or .so.
(which in wasm parlance means a command pattern module with a _start function)
I thought the presence of a main function is what determines whether or not it is a command or reactor module
There was a problem hiding this comment.
How about this:
Change your `Cargo.toml` to set the crate-type to `cdylib` (this instructs the compiler to produce a dynamic library, which for our target will be a Wasm file):
There was a problem hiding this comment.
If you're writing in c or rust your "main" function is called main in the source, but when it turns into wasm it becomes can export called _start
There was a problem hiding this comment.
I meant as opposed to a .dylib or .so
That would be determined by the target flag. This is from the wasm-pack doc but relevant:
Here though crate-type = ["cdylib"] typically signifies that you'd like the compiler to create a dynamic system library, but for WebAssembly target it simply means "create a *.wasm file without a start function". On other platforms this output type will create *.so file on Linux, *.dylib on macOS, and *.dll Windows.
There was a problem hiding this comment.
👍 I think that definition is in line with my latest update
README.md
Outdated
| @@ -259,8 +259,7 @@ pub fn hello_from_python() -> FnResult<String> { | |||
| ### Testing it out | |||
|
|
|||
| We can't really test this from the Extism CLI as something must provide the implementation. So let's | |||
| write out the python side here. You should check the docs for the language you're using on the host side | |||
| for how to implement host functions. | |||
| write out the Python side here. Check out the [docs for the host SDKs](https://extism.org/docs/category/integrate-into-your-codebase) to implement a host function in a language of your choice. | |||
There was a problem hiding this comment.
This page will be going away I think. Might be better to link to the Host SDK concept doc?
No description provided.