feat: Added auto, always, never modifiers to --hyperlink argument (V2)
#1059
Conversation
… can Co-authored-by: Milo Moisson <[email protected]>
Co-authored-by: Milo Moisson <[email protected]>
Co-authored-by: Milo Moisson <[email protected]>
nikelborm
requested review from
MartinFillon,
PThorpe92 and
cafkafk
as code owners
|
I can merge shell completions updates into my branch, but I don't see how this PR resolves what was blocking on mine. |
When I started doing it, I started doing it myself following already established patterns in the current project. But I started doing it on top of the latest main branch. Then I found your PR that looked similar and merged what i done with what you did and mentioned you in the commits where our changes looked similar. I didn't really tested what kind of conflicts exist on your branch, I just looked on github's banner |
|
For conflicts, you have rebasing. But that's not blocking. The issue we had was that hyperlink OSCs were not taken into account when calculating width and that end up messing with the I just rebased and force-pushed on my end. Works fine apparently. |
This is continuation of @mrnossiom's work in #746 (as I've learned already after I started coding current PR myself) with added shell completions and which doesn't have merge conflicts with the
mainbranch.Description
Add a
WHENmodifier to the--hyperlinkargument. This matches bothlsbehavior and the--colorargument behavior.I think
lsis doing it right because you might want to enable--hyperlinkin a shell alias but still get plain text when piping into some other program without control chars in the way. Setting--hyperlinkin a shell alias is useful for terminal integration (e.g. Kitty).The public API is compatible since
--hyperlinkdefaults toautoand doesn't break. However, it changes the behavior, with no value the option worked likealwaysbut it now defaults toauto. Even though I considerautoto be the right default, maybe it could be changed toalwaysto keep old meaning.