-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: colour file kind indicators #1184
base: main
Are you sure you want to change the base?
Conversation
4528a92
to
c545e19
Compare
c545e19
to
5e8be75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some context for what motivates this change?
I actually think think makes sense, I cannot think of any reason why not. So if it's cool with others, LGTM 👍 EDIT: I am assuming that this allows it to be configurable within the theme file, I actually haven't looked close enough to double check this is the case but it seems like a safe assumption. |
Yeah, punctuation is part styles configurable via |
Uses the punctuation style.
5e8be75
to
a0ce277
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased main and tested that styling via theme.yml
works. It does, great! ... Code looks good to me. Thanks!
@cafkafk At the moment punctuation in paths like the directory slashes simply take the default color gray and are not configurable. This fix gives adds these chars to punctuation style making it Without this fix, the directory slashes in this screenshot would stay gray even after setting the punctuation color to red. |
Uses the punctuation style.
Tested using
nix run . -- -F
andnix run . -- -lF
.Wasn't sure if I should use "fix" or "feat" in the commit message. Hope this is okay.