Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: colour file kind indicators #1184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bee-plus
Copy link

@bee-plus bee-plus commented Oct 8, 2024

Uses the punctuation style.

Tested using nix run . -- -F and nix run . -- -lF.

Wasn't sure if I should use "fix" or "feat" in the commit message. Hope this is okay.

@bee-plus bee-plus force-pushed the colour-file-kind-indicators branch 2 times, most recently from 4528a92 to c545e19 Compare October 8, 2024 13:53
@cafkafk cafkafk force-pushed the colour-file-kind-indicators branch from c545e19 to 5e8be75 Compare November 28, 2024 06:40
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add some context for what motivates this change?

@bee-plus
Copy link
Author

can you add some context for what motivates this change?

Sure! I wanted to style them, but I couldn't find a way to do so. Using the existing punctuation style seemed like a reasonable choice.

Before:

After:

@PThorpe92
Copy link
Member

PThorpe92 commented Nov 30, 2024

I actually think think makes sense, I cannot think of any reason why not. So if it's cool with others, LGTM 👍

EDIT: I am assuming that this allows it to be configurable within the theme file, I actually haven't looked close enough to double check this is the case but it seems like a safe assumption.

@gierens
Copy link
Member

gierens commented Dec 3, 2024

Yeah, punctuation is part styles configurable via theme.yml ... Code looks good to me, I'll test is out tomorrow and then give an actual review.

Uses the punctuation style.
@gierens gierens force-pushed the colour-file-kind-indicators branch from 5e8be75 to a0ce277 Compare December 4, 2024 08:25
Copy link
Member

@gierens gierens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased main and tested that styling via theme.yml works. It does, great! ... Code looks good to me. Thanks!

@gierens
Copy link
Member

gierens commented Dec 4, 2024

can you add some context for what motivates this change?

@cafkafk At the moment punctuation in paths like the directory slashes simply take the default color gray and are not configurable. This fix gives adds these chars to punctuation style making it
configurable:

Screenshot From 2024-12-04 09-37-24

Without this fix, the directory slashes in this screenshot would stay gray even after setting the punctuation color to red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

4 participants