Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add --sort=blocks #1190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add --sort=blocks #1190

wants to merge 1 commit into from
+22 −3

Conversation

monoid
Copy link

@monoid monoid commented Oct 13, 2024

This features allow to sort by files' block size (the value printed by the -S option).

Also, it has variants --sort=block and --sort=blocksize which do the same.

MartinFillon
MartinFillon requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@MartinFillon MartinFillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for the pr, would you mind please writing some test cases, if possible in order to make sure it always keeps the same behaviour.

@monoid
Copy link
Author

monoid commented Oct 18, 2024 •
edited
Loading

I'm sorry, I struggled with Nix but I can't resolve the --extra-experimental-features problem. It needs more time than I can afford to spend.

@monoid @cafkafk
feat: add --sort=blocks
0cced3b 
This features allow to sort by files' block size (the value printed by
the `-S` option).
@cafkafk cafkafk force-pushed the feat/sort-by-block-size branch from 587ffce to 0cced3b Compare October 18, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinFillon MartinFillon MartinFillon requested changes

@cafkafk cafkafk Awaiting requested review from cafkafk cafkafk is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Eza Pull-Requests
Status: 🆕 New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monoid @MartinFillon