chore: fix, add and sort icons #1274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafkafk
requested changes
Dec 28, 2024
Freed-Wu
force-pushed
the
icon
branch
4 times, most recently
from
b9ff04f to
2a5d471
Compare
Fix: ruby's official logo is falling down: https://www.ruby-lang.org/en/about/logo/ *.com is DOS binary format: https://en.wikipedia.org/wiki/COM_file use editorconfig logo for .editorconfig bare metal programs also use *.lib and *.a as their static library extension use linux icon is not appropriate however, bare metal programs don't support dynamic library so use windows icon for *.dll use vim icon for _vimrc and _gvimrc, which are vimrc filename on windows use fennel icon for .fennelrc and fennelrc Add some missing icons from: - https://github.com/lambdalisue/vim-nerdfont/blob/master/assets/json/extension.json - https://github.com/lambdalisue/vim-nerdfont/blob/master/assets/json/basename.json Sort them alphabetically
|
Sort often bring conflict when new icon is added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
ruby's official logo is falling down: https://www.ruby-lang.org/en/about/logo/
*.com is DOS binary format: https://en.wikipedia.org/wiki/COM_file
use editorconfig logo for .editorconfig
bare metal programs also use *.lib and *.a as their static library extension
use linux icon is not appropriate
however, bare metal programs don't support dynamic library
so use windows icon for *.dll
use vim icon for _vimrc and _gvimrc, which are vimrc filename on windows
use fennel icon for .fennelrc and fennelrc
Add some missing icons from:
Sort them alphabetically
Description
How Has This Been Tested?