Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS2-1480 Add SwiftLint plugin & config #31

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

capnsolo
Copy link
Collaborator

@capnsolo capnsolo commented Nov 21, 2023

  • add plugin & config
  • set minimum OS version to 14.0
  • fix violations

Notes

  • the first time you build with the plugin, Xcode will prompt you and you'll have to "Trust & Enable" the plugin before it can run
  • the plugin didn't work for me at first; changing the name of my Xcode app back to "Xcode" fixed it (I had previously named it "Xcode 15.1 beta" when I had multiple versions installed)
  • most of the changes are cleaning up trailing whitespace; I recommend hiding whitespace in the Github editor or looking at the commits individually
  • the output in the build log is different than in the apps:

issues found:
Screenshot 2023-11-21 at 10 04 18 AM

no issues:
Screenshot 2023-11-21 at 10 02 06 AM

@capnsolo capnsolo marked this pull request as ready for review November 21, 2023 16:55
@capnsolo capnsolo requested a review from a team as a code owner November 21, 2023 16:55
Copy link
Contributor

@yangchen83 yangchen83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@capnsolo capnsolo merged commit 94e50f3 into master Nov 21, 2023
2 checks passed
@capnsolo capnsolo deleted the chore/capnsolo/1480-swiftlint branch November 21, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants